fix(ci): ensure container image is built before e2e tests #17408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible for the "fetch container from Depot" step in the e2e tests to not find a cached container - this is because currently it is relying on the
container-images-ci.ymlworkflow to build the container, but it's effectively a race condition which one starts first.This results in longer builds, since each of the 11 workflows starts its own build, and this consumes unnecessary Depot build minutes.
Changes
To mitigate this, this PR adds a
containerbuild job to theci-e2e.ymlworkflow, as a dependency of thecypressmatrix job. This ensures that the container will be fully built and present in the cache before it's pulled to each of the 11 matrix jobs withload: trueHow did you test this code?
This hasn't been tested, given it runs in Actions.